Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component/playground: rm the restriction that tikv num must be greater than 0 #2073

Merged
merged 4 commits into from
Nov 14, 2022
Merged

component/playground: rm the restriction that tikv num must be greater than 0 #2073

merged 4 commits into from
Nov 14, 2022

Conversation

lilinghai
Copy link
Contributor

Signed-off-by: lilinghai lilinghai@pingcap.com

What problem does this PR solve?

In order to construct a pd with monitor quickly in pd test, we remove the restriction thas tikv num must be greater than 0.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@lilinghai
component/playground: rm the restriction that tikv num must be greate…
91b24ee 
…r than 0

Signed-off-by: lilinghai <lilinghai@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2022
@nexustar
Copy link
Collaborator

nexustar commented Nov 9, 2022

please modify the error message together

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022 •
edited
Loading

Codecov Report

Base: 56.79% // Head: 51.41% // Decreases project coverage by -5.38% ⚠️

Coverage data is based on head (02f2ecd) compared to base (1ca7132).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2073      +/-   ##
==========================================
- Coverage   56.79%   51.41%   -5.38%     
==========================================
  Files         313      312       -1     
  Lines       33177    33166      -11     
==========================================
- Hits        18840    17050    -1790     
- Misses      12102    13888    +1786     
+ Partials     2235     2228       -7
Flag Coverage Δ
tiup 16.47% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 50.94% <0.00%> (ø)
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-70.73%) ⬇️
pkg/utils/error.go 0.00% <0.00%> (-64.29%) ⬇️
components/dm/ansible/import.go 0.00% <0.00%> (-61.28%) ⬇️
pkg/telemetry/scrub.go 12.31% <0.00%> (-60.00%) ⬇️
pkg/cluster/executor/local.go 0.00% <0.00%> (-59.38%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lilinghai
Copy link
Contributor Author

please modify the error message together

done

@nexustar
Copy link
Collaborator

please sign the CLA

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2022
@nexustar
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cbf943

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@ti-chi-bot ti-chi-bot merged commit 63d509b into pingcap:master Nov 14, 2022
@nexustar nexustar added this to the 1.11.1 milestone Nov 15, 2022
nexustar pushed a commit that referenced this pull request Nov 22, 2022
@lilinghai @kaaaaaaang
component/playground: rm the restriction that tikv num must be greate…
45668e5 
…r than 0 (#2073)
nexustar pushed a commit that referenced this pull request Nov 23, 2022
@lilinghai @kaaaaaaang
component/playground: rm the restriction that tikv num must be greate…
4d3dc8b 
…r than 0 (#2073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexustar nexustar nexustar approved these changes

@lonng lonng Awaiting requested review from lonng

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lilinghai @ti-chi-bot @CLAassistant @nexustar @codecov-commenter